gh-93096: fix test_mimetypes.test_guess_type_conflicting_with_mimetypes#131408
Merged
hugovk merged 11 commits intopython:mainfrom Apr 8, 2025
Merged
gh-93096: fix test_mimetypes.test_guess_type_conflicting_with_mimetypes#131408hugovk merged 11 commits intopython:mainfrom
test_mimetypes.test_guess_type_conflicting_with_mimetypes#131408hugovk merged 11 commits intopython:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
run_python_until_end()ignoressetUpModule(). In particular, mockingmimetypes.knownfileshas no effect for the CLI tests and leads to issues on platforms defining non-standard MIME types such as macOS or openSUSE.I think this was overlooked in #93097 and this may be the reason why finding the correct extension was tedious. Now, all platforms should support the test correctly (previously, the macOS files were still looked up as
mimetypes.knownfileswas not unset for CLI tests).